Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relay): add SO_REUSEPORT flag to enable smooth restarts #4375

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Dec 12, 2024

This PR sets the SO_REUSEPORT flag to the TcpSocket to prevent bind to interface failed: Address already in use (os error 98) errors when restarting

@Litarnus Litarnus linked an issue Dec 12, 2024 that may be closed by this pull request
@Litarnus Litarnus marked this pull request as ready for review December 12, 2024 13:52
@Litarnus Litarnus requested a review from a team as a code owner December 12, 2024 13:52
CHANGELOG.md Outdated
@@ -26,6 +26,7 @@
- Promote some `span.data` fields to the top level. ([#4298](https://github.com/getsentry/relay/pull/4298))
- Remove metrics summaries. ([#4278](https://github.com/getsentry/relay/pull/4278), [#4279](https://github.com/getsentry/relay/pull/4279), [#4296](https://github.com/getsentry/relay/pull/4296))
- Use async `redis` for `projectconfig`. ([#4284](https://github.com/getsentry/relay/pull/4284))
- Set `SO_REUSEPORT` to enable smooth restarts. ([#4375](https://github.com/getsentry/relay/pull/4375))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this to `Bug Fixes"?

@Litarnus Litarnus merged commit efefcca into master Dec 12, 2024
23 checks passed
@Litarnus Litarnus deleted the martinl/reuseport branch December 12, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SO_REUSEPORT for smooth restart
2 participants